From d4c6fe18ca94ed0880720d7ff135b82920d764b4 Mon Sep 17 00:00:00 2001
From: Clyhtsuriva <aimeric@adjutor.xyz>
Date: Sun, 27 Jun 2021 11:16:21 +0200
Subject: XMLHandler tests covered at 91%

---
 src/test/java/musichub/util/LogHandlerTest.java     | 20 ++++++++++----------
 src/test/java/musichub/util/PathValidationTest.java | 20 ++++++++++----------
 src/test/java/musichub/util/XMLHandlerTest.java     | 14 +++++++-------
 3 files changed, 27 insertions(+), 27 deletions(-)

(limited to 'src')

diff --git a/src/test/java/musichub/util/LogHandlerTest.java b/src/test/java/musichub/util/LogHandlerTest.java
index 17b47f6..3965520 100644
--- a/src/test/java/musichub/util/LogHandlerTest.java
+++ b/src/test/java/musichub/util/LogHandlerTest.java
@@ -11,6 +11,16 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class LogHandlerTest {
+    @Test
+    void testLogHandlerClass() {
+        try {
+            LogHandler logHandlerClass = new LogHandler();
+        } catch (Error e) {
+            assertTrue(e instanceof AssertionError);
+            assertEquals("You just can't instantiate this class.", e.getMessage());
+        }
+    }
+
     @Test
     void testWrite() {
         try {
@@ -28,14 +38,4 @@ public class LogHandlerTest {
             e.printStackTrace();
         }
     }
-
-    @Test
-    void testLogHandlerClass() {
-        try {
-            LogHandler logHandlerClass = new LogHandler();
-        } catch (Error ex) {
-            assertTrue(ex instanceof AssertionError);
-            assertEquals("You just can't instantiate this class.", ex.getMessage());
-        }
-    }
 }
diff --git a/src/test/java/musichub/util/PathValidationTest.java b/src/test/java/musichub/util/PathValidationTest.java
index 4c7a3d6..b0e0c38 100644
--- a/src/test/java/musichub/util/PathValidationTest.java
+++ b/src/test/java/musichub/util/PathValidationTest.java
@@ -7,20 +7,20 @@ import static musichub.util.PathValidation.isPathValid;
 import static org.junit.jupiter.api.Assertions.*;
 
 public class PathValidationTest {
-    @Test
-    void testIsPathValid() {
-        assertTrue(isPathValid("Song/Side_To_Side.wav")); //the right path
-        assertFalse(isPathValid("wrong_path/Side_To_Side.wav")); //wrong path
-        assertFalse(isPathValid("Song/Side_To_Side.mp3")); //wrong extension
-    }
-
     @Test
     void testPathValidationClass() {
         try {
             PathValidation pathValidationClass = new PathValidation();
-        } catch (Error ex) {
-            assertTrue(ex instanceof AssertionError);
-            assertEquals("You just can't instantiate this class.", ex.getMessage());
+        } catch (Error e) {
+            assertTrue(e instanceof AssertionError);
+            assertEquals("You just can't instantiate this class.", e.getMessage());
         }
     }
+
+    @Test
+    void testIsPathValid() {
+        assertTrue(isPathValid("Song/Side_To_Side.wav")); //the right path
+        assertFalse(isPathValid("wrong_path/Side_To_Side.wav")); //wrong path
+        assertFalse(isPathValid("Song/Side_To_Side.mp3")); //wrong extension
+    }
 }
diff --git a/src/test/java/musichub/util/XMLHandlerTest.java b/src/test/java/musichub/util/XMLHandlerTest.java
index 1be2258..7b5a791 100644
--- a/src/test/java/musichub/util/XMLHandlerTest.java
+++ b/src/test/java/musichub/util/XMLHandlerTest.java
@@ -10,11 +10,6 @@ public class XMLHandlerTest {
     final String DIR = System.getProperty("user.dir");
     final String JUNIT_FILE_PATH = DIR + "/files/JUnit.xml";
 
-/*    @Test
-    void testXMLHandlerClass() {
-            XMLHandler xmlHandler = new XMLHandler();
-    }*/
-
     @Test
     void testCreateXML() {
         XMLHandler xmlHandler = new XMLHandler(); //XML class
@@ -24,7 +19,12 @@ public class XMLHandlerTest {
 
     @Test
     void testParseXMLFile() {
+        final String PARSE_DIR = System.getProperty("user.dir");
+        final String PARSE_FILE_PATH = PARSE_DIR + "/files/parse_JUnit.xml";
         XMLHandler xmlHandler = new XMLHandler();
-        NodeList albumNodes = xmlHandler.parseXMLFile(JUNIT_FILE_PATH);
+        //wrong content of file resulting in an exception, will print it during test but it's normal
+        NodeList junitNodes = xmlHandler.parseXMLFile(JUNIT_FILE_PATH);
+        //right content of file
+        NodeList parseNodes = xmlHandler.parseXMLFile(PARSE_FILE_PATH);
     }
-}
+}
\ No newline at end of file
-- 
cgit v1.2.3