From d4c6fe18ca94ed0880720d7ff135b82920d764b4 Mon Sep 17 00:00:00 2001 From: Clyhtsuriva Date: Sun, 27 Jun 2021 11:16:21 +0200 Subject: XMLHandler tests covered at 91% --- src/test/java/musichub/util/LogHandlerTest.java | 20 ++++++++++---------- src/test/java/musichub/util/PathValidationTest.java | 20 ++++++++++---------- src/test/java/musichub/util/XMLHandlerTest.java | 14 +++++++------- 3 files changed, 27 insertions(+), 27 deletions(-) (limited to 'src/test') diff --git a/src/test/java/musichub/util/LogHandlerTest.java b/src/test/java/musichub/util/LogHandlerTest.java index 17b47f6..3965520 100644 --- a/src/test/java/musichub/util/LogHandlerTest.java +++ b/src/test/java/musichub/util/LogHandlerTest.java @@ -11,6 +11,16 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertTrue; public class LogHandlerTest { + @Test + void testLogHandlerClass() { + try { + LogHandler logHandlerClass = new LogHandler(); + } catch (Error e) { + assertTrue(e instanceof AssertionError); + assertEquals("You just can't instantiate this class.", e.getMessage()); + } + } + @Test void testWrite() { try { @@ -28,14 +38,4 @@ public class LogHandlerTest { e.printStackTrace(); } } - - @Test - void testLogHandlerClass() { - try { - LogHandler logHandlerClass = new LogHandler(); - } catch (Error ex) { - assertTrue(ex instanceof AssertionError); - assertEquals("You just can't instantiate this class.", ex.getMessage()); - } - } } diff --git a/src/test/java/musichub/util/PathValidationTest.java b/src/test/java/musichub/util/PathValidationTest.java index 4c7a3d6..b0e0c38 100644 --- a/src/test/java/musichub/util/PathValidationTest.java +++ b/src/test/java/musichub/util/PathValidationTest.java @@ -7,20 +7,20 @@ import static musichub.util.PathValidation.isPathValid; import static org.junit.jupiter.api.Assertions.*; public class PathValidationTest { - @Test - void testIsPathValid() { - assertTrue(isPathValid("Song/Side_To_Side.wav")); //the right path - assertFalse(isPathValid("wrong_path/Side_To_Side.wav")); //wrong path - assertFalse(isPathValid("Song/Side_To_Side.mp3")); //wrong extension - } - @Test void testPathValidationClass() { try { PathValidation pathValidationClass = new PathValidation(); - } catch (Error ex) { - assertTrue(ex instanceof AssertionError); - assertEquals("You just can't instantiate this class.", ex.getMessage()); + } catch (Error e) { + assertTrue(e instanceof AssertionError); + assertEquals("You just can't instantiate this class.", e.getMessage()); } } + + @Test + void testIsPathValid() { + assertTrue(isPathValid("Song/Side_To_Side.wav")); //the right path + assertFalse(isPathValid("wrong_path/Side_To_Side.wav")); //wrong path + assertFalse(isPathValid("Song/Side_To_Side.mp3")); //wrong extension + } } diff --git a/src/test/java/musichub/util/XMLHandlerTest.java b/src/test/java/musichub/util/XMLHandlerTest.java index 1be2258..7b5a791 100644 --- a/src/test/java/musichub/util/XMLHandlerTest.java +++ b/src/test/java/musichub/util/XMLHandlerTest.java @@ -10,11 +10,6 @@ public class XMLHandlerTest { final String DIR = System.getProperty("user.dir"); final String JUNIT_FILE_PATH = DIR + "/files/JUnit.xml"; -/* @Test - void testXMLHandlerClass() { - XMLHandler xmlHandler = new XMLHandler(); - }*/ - @Test void testCreateXML() { XMLHandler xmlHandler = new XMLHandler(); //XML class @@ -24,7 +19,12 @@ public class XMLHandlerTest { @Test void testParseXMLFile() { + final String PARSE_DIR = System.getProperty("user.dir"); + final String PARSE_FILE_PATH = PARSE_DIR + "/files/parse_JUnit.xml"; XMLHandler xmlHandler = new XMLHandler(); - NodeList albumNodes = xmlHandler.parseXMLFile(JUNIT_FILE_PATH); + //wrong content of file resulting in an exception, will print it during test but it's normal + NodeList junitNodes = xmlHandler.parseXMLFile(JUNIT_FILE_PATH); + //right content of file + NodeList parseNodes = xmlHandler.parseXMLFile(PARSE_FILE_PATH); } -} +} \ No newline at end of file -- cgit v1.2.3 athValidationTest.java?id=8e72cabd763c8f6cfba63b9aaf9502ca15a3092f&follow=1'>Moved PathValidation to the util packageClyhtsuriva3-4/+4 2021-06-26Delete spoteezer.imlClyhtsuriva1-11/+0 2021-06-26Updated javadoc, added jacoco and the necessary JUnit for this feature.Clyhtsuriva128-78/+3725 2021-06-26Applying the latest package architecture.Clyhtsuriva9-3/+47 2021-06-26Modified compile.bat and run.bat to use maven.Clyhtsuriva2-2/+2 2021-06-26Delete out/production/spoteezer/musichub directoryClyhtsuriva17-0/+0 2021-06-26Removed reduced pom and added the content of STZ-0001 with a switch modif.Clyhtsuriva65-149/+208 2021-06-26Delete .classpathClyhtsuriva1-6/+0 2021-06-26Delete .projectClyhtsuriva1-17/+0 2021-06-26Delete .idea directoryClyhtsuriva4-28/+0 2021-06-26UpdateClyhtsuriva50-84/+84 2021-06-26Changed the architecture to respect maven and generated an empty javadocClyhtsuriva129-23/+7829 2021-06-26Add reset, pause, quit functionalitysaid belhadj46-18/+100 2021-06-26Adding the pom.xml and target folder created from mvn package.Clyhtsuriva6-0/+164 2021-06-26Add the possibility to listen a song thanks to Audio System librarysaid belhadj7-4/+55 2021-06-25Fixing STZ-0004 issue.Clyhtsuriva1-1/+3 2021-06-17Delete initial_class_diagram.pngClyhtsuriva1-0/+0