From ac929460d07e0d0ef8c6b4ea569a2b2c6daa3b13 Mon Sep 17 00:00:00 2001 From: Clyhtsuriva Date: Tue, 23 Mar 2021 11:47:53 +0100 Subject: Refactoring into MVC --- .../aniki/manga/topmanga/DetailTopMangaActivity.kt | 193 --------------------- .../xyz/adjutor/aniki/manga/topmanga/TopManga.kt | 35 ---- .../aniki/manga/topmanga/TopMangaAdapter.kt | 81 --------- .../adjutor/aniki/manga/topmanga/TopMangaApi.kt | 12 -- .../adjutor/aniki/manga/topmanga/TopMangaPage.kt | 174 ------------------- .../aniki/manga/topmanga/TopMangaResponse.kt | 13 -- 6 files changed, 508 deletions(-) delete mode 100644 app/src/main/java/xyz/adjutor/aniki/manga/topmanga/DetailTopMangaActivity.kt delete mode 100644 app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopManga.kt delete mode 100644 app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaAdapter.kt delete mode 100644 app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaApi.kt delete mode 100644 app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaPage.kt delete mode 100644 app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaResponse.kt (limited to 'app/src/main/java/xyz/adjutor/aniki/manga/topmanga') diff --git a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/DetailTopMangaActivity.kt b/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/DetailTopMangaActivity.kt deleted file mode 100644 index 6d89437..0000000 --- a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/DetailTopMangaActivity.kt +++ /dev/null @@ -1,193 +0,0 @@ -package xyz.adjutor.aniki.manga.topmanga - -import android.content.Context -import android.content.SharedPreferences -import android.os.Bundle -import android.widget.ImageView -import android.widget.TextView -import android.widget.Toast -import androidx.appcompat.app.AppCompatActivity -import com.bumptech.glide.Glide -import com.bumptech.glide.request.RequestOptions -import com.google.gson.GsonBuilder -import com.google.gson.reflect.TypeToken -import retrofit2.Call -import retrofit2.Callback -import retrofit2.Response -import retrofit2.Retrofit -import retrofit2.converter.gson.GsonConverterFactory -import xyz.adjutor.aniki.R -import xyz.adjutor.aniki.manga.MangaApi -import xyz.adjutor.aniki.manga.MangaResponse -import java.lang.reflect.Type - -class DetailTopMangaActivity : AppCompatActivity() { - - private var baseUrl = "https://api.jikan.moe/" - private lateinit var sharedPreferences: SharedPreferences - private val gson = GsonBuilder() - .setLenient() - .create() - - //used in the list - private val intentMangaTitle = "themangatitle" - private val intentMangaRank = "themangarank" - private val intentMangaScore = "themangascore" - private val intentMangaImageUrl = "themangaimageurl" - - //only used for the detail - private val intentMangaId = "themangaid" - private val intentMangaVolumes = "themangavolumes" - private val intentMangaStartDate = "themangastartdate" - private val intentMangaEndDate = "themangaenddate" - private val intentMangaUrl = "themangaurl" - - override fun onCreate(savedInstanceState: Bundle?) { - super.onCreate(savedInstanceState) - setContentView(R.layout.activity_detail_top_manga) - - sharedPreferences = this.getSharedPreferences("sp_manga", Context.MODE_PRIVATE) - - val mangaTitle = intent.getStringExtra(intentMangaTitle) - val mangaRank = intent.getStringExtra(intentMangaRank) - val mangaScore = intent.getStringExtra(intentMangaScore) - val mangaImageUrl = intent.getStringExtra(intentMangaImageUrl) - - val mangaId = intent.getStringExtra(intentMangaId) - val mangaVolumes = intent.getStringExtra(intentMangaVolumes) - val mangaStartDate = intent.getStringExtra(intentMangaStartDate) - val mangaEndDate = intent.getStringExtra(intentMangaEndDate) - val mangaUrl = intent.getStringExtra(intentMangaUrl) - - val tvTitle: TextView = findViewById(R.id.tv_detail_title) - val tvRank: TextView = findViewById(R.id.tv_detail_rank) - val tvScore: TextView = findViewById(R.id.tv_detail_score) - val ivImage: ImageView = findViewById(R.id.iv_detail_image) - - val tvId: TextView = findViewById(R.id.tv_detail_id) - val tvVolumes: TextView = findViewById(R.id.tv_volumes) - val tvStartDate: TextView = findViewById(R.id.tv_start_date) - val tvEndDate: TextView = findViewById(R.id.tv_end_date) - val tvUrl: TextView = findViewById(R.id.tv_url) - - tvTitle.text = mangaTitle - tvRank.text = mangaRank - tvScore.text = mangaScore - Glide - .with(this) - .load(mangaImageUrl) - .apply(RequestOptions().override(400)) - .into(ivImage) - - tvId.text = mangaId - - //using null as a string because it has been converted to a string before - tvVolumes.text = if (mangaVolumes != "null") { - mangaVolumes - } else { - fieldIsNull() - } - - tvStartDate.text = mangaStartDate - - tvEndDate.text = if (mangaEndDate != "null") { - mangaEndDate - } else { - fieldIsNull() - } - - tvUrl.text = mangaUrl - - val manga: MangaResponse? = getDataFromCache(mangaId.toString()) - if (manga != null) { - showDetail(manga) - } else { - //taking the API's fields I want and displaying them - makeApiCall(baseUrl, mangaId.toString()) - } - - } - - private fun getDataFromCache(mangaId: String): MangaResponse? { - val jsonManga: String? = sharedPreferences.getString(mangaId, null) - - return if (jsonManga == null) { - null - } else { - val type: Type = object : TypeToken() {}.type - gson.fromJson(jsonManga, type) - } - } - - private fun makeApiCall(BASE_URL: String, mangaId: String) { - - val retrofit = Retrofit.Builder() - .baseUrl(BASE_URL) - .addConverterFactory(GsonConverterFactory.create(gson)) - .build() - - val service = retrofit.create(MangaApi::class.java) - val call = service.getMangaData(mangaId) //based on the id - - call.enqueue(object : Callback { - override fun onResponse( - call: Call, - response: Response - ) { - if (response.isSuccessful && response.body() != null) { //if the code returned is >= 200 and < 300 AND the the body ain't empty - - val manga = response.body() //getting the MangaResponse fields - saveList(manga) - showDetail(manga!!) - - } else { - showError("API ERROR : is not successful") - } - } - - override fun onFailure(call: Call, t: Throwable) { - showError("API ERROR : onFailure") - } - - }) - } - - private fun showDetail(manga: MangaResponse) { - //elements from MangaResponse - val tvChapters: TextView = findViewById(R.id.tv_chapters) - val tvSynopsis: TextView = findViewById(R.id.tv_synopsis) - val tvBackground: TextView = findViewById(R.id.tv_background) - - tvChapters.text = if (manga.chapters != null) { - manga.chapters.toString() - } else { - fieldIsNull() - } - - tvSynopsis.text = manga.synopsis.toString() - - tvBackground.text = if (manga.background != null) { - manga.background.toString() - } else { - fieldIsNull() - } - - } - - fun showError(text: String) { - Toast.makeText(this, text, Toast.LENGTH_LONG).show() - } - - private fun fieldIsNull(): String { - return "Unknown" - } - - fun saveList(manga: MangaResponse?) { - val jsonString: String = gson.toJson(manga) - - sharedPreferences - .edit() - .putString(manga?.mal_id.toString(), jsonString) - .apply() - } -} \ No newline at end of file diff --git a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopManga.kt b/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopManga.kt deleted file mode 100644 index 2ceceea..0000000 --- a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopManga.kt +++ /dev/null @@ -1,35 +0,0 @@ -package xyz.adjutor.aniki.manga.topmanga - -import com.google.gson.annotations.SerializedName - -//Content of the top field from the api of top manga -class TopManga { - - @SerializedName("mal_id") - var mal_id: Int? = null - - @SerializedName("rank") - var rank: Int? = null - - @SerializedName("title") - var title: String? = null - - @SerializedName("url") - var url: String? = null - - @SerializedName("volumes") - var volumes: Int? = null - - @SerializedName("start_date") - var start_date: String? = null - - @SerializedName("end_date") - var end_date: String? = null - - @SerializedName("score") - var score: Float? = null - - @SerializedName("image_url") - var image_url: String? = null - -} diff --git a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaAdapter.kt b/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaAdapter.kt deleted file mode 100644 index d0c56f7..0000000 --- a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaAdapter.kt +++ /dev/null @@ -1,81 +0,0 @@ -package xyz.adjutor.aniki.manga.topmanga - -import android.content.Intent -import android.view.LayoutInflater -import android.view.View -import android.view.ViewGroup -import android.widget.ImageView -import android.widget.TextView -import androidx.cardview.widget.CardView -import androidx.recyclerview.widget.RecyclerView -import com.bumptech.glide.Glide -import com.bumptech.glide.request.RequestOptions -import xyz.adjutor.aniki.R - -class TopMangaAdapter(private val mangaList: List) : - RecyclerView.Adapter() { - - // Describes an item view and its place within the RecyclerView - class MangaViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) { - val mangaTitle: TextView = itemView.findViewById(R.id.tv_title) - val mangaRank: TextView = itemView.findViewById(R.id.tv_rank) - val mangaScore: TextView = itemView.findViewById(R.id.tv_score) - val mangaImage: ImageView = itemView.findViewById(R.id.iv_image) - val cardview: CardView = itemView.findViewById(R.id.cv_cardView) - } - - // Returns a new ViewHolder - override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): MangaViewHolder { - val view = LayoutInflater.from(parent.context) - .inflate(R.layout.item_layout, parent, false) - - return MangaViewHolder(view) - } - - // Returns size of data list - override fun getItemCount(): Int { - return mangaList.size - } - - // Displays data at a certain position - override fun onBindViewHolder(holder: MangaViewHolder, position: Int) { - val currentManga: TopManga = mangaList[position] - holder.mangaTitle.text = currentManga.title - holder.mangaRank.text = currentManga.rank.toString() - holder.mangaScore.text = currentManga.score.toString() - val image: String = currentManga.image_url.toString() - Glide - .with(holder.itemView.context) - .load(image) - .apply(RequestOptions().override(400)) - .into(holder.mangaImage) - - //when you click on a selected cardview, some datas are sent to the other activity - holder.cardview.setOnClickListener { - val currentMangaId = "themangaid" - val currentMangaTitle = "themangatitle" - val currentMangaRank = "themangarank" - val currentMangaScore = "themangascore" - val currentMangaImageUrl = "themangaimageurl" - val currentMangaVolumes = "themangavolumes" - val currentMangaStartDate = "themangastartdate" - val currentMangaEndDate = "themangaenddate" - val currentMangaUrl = "themangaurl" - - //intent is used to pass data to another activity - val intent: Intent = - Intent(holder.itemView.context, DetailTopMangaActivity::class.java).apply { - putExtra(currentMangaId, currentManga.mal_id.toString()) - putExtra(currentMangaTitle, currentManga.title) - putExtra(currentMangaRank, currentManga.rank.toString()) - putExtra(currentMangaScore, currentManga.score.toString()) - putExtra(currentMangaImageUrl, currentManga.image_url.toString()) - putExtra(currentMangaVolumes, currentManga.volumes.toString()) - putExtra(currentMangaStartDate, currentManga.start_date) - putExtra(currentMangaEndDate, currentManga.end_date.toString()) - putExtra(currentMangaUrl, currentManga.url.toString()) - } - holder.itemView.context.startActivity(intent) - } - } -} \ No newline at end of file diff --git a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaApi.kt b/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaApi.kt deleted file mode 100644 index 2688fab..0000000 --- a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaApi.kt +++ /dev/null @@ -1,12 +0,0 @@ -package xyz.adjutor.aniki.manga.topmanga - -import retrofit2.Call -import retrofit2.http.GET -import retrofit2.http.Path - -interface TopMangaApi { - - @GET("v3/top/manga/{page}") - fun getTopMangaData(@Path("page") page: Int): Call - -} \ No newline at end of file diff --git a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaPage.kt b/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaPage.kt deleted file mode 100644 index 9c138a3..0000000 --- a/app/src/main/java/xyz/adjutor/aniki/manga/topmanga/TopMangaPage.kt +++ /dev/null @@ -1,174 +0,0 @@ -package xyz.adjutor.aniki.manga.topmanga - -import android.content.Context -import android.content.SharedPreferences -import android.os.Bundle -import android.view.LayoutInflater -import android.view.View -import android.view.ViewGroup -import android.widget.Button -import androidx.fragment.app.Fragment -import androidx.navigation.fragment.findNavController -import androidx.recyclerview.widget.LinearLayoutManager -import androidx.recyclerview.widget.RecyclerView -import androidx.swiperefreshlayout.widget.SwipeRefreshLayout -import com.google.android.material.snackbar.Snackbar -import com.google.gson.Gson -import com.google.gson.GsonBuilder -import com.google.gson.reflect.TypeToken -import retrofit2.Call -import retrofit2.Callback -import retrofit2.Response -import retrofit2.Retrofit -import retrofit2.converter.gson.GsonConverterFactory -import xyz.adjutor.aniki.R -import java.lang.reflect.Type - -class TopMangaPage : Fragment() { - - private lateinit var sharedPreferences: SharedPreferences - val gson: Gson = GsonBuilder() - .setLenient() - .create() - private var baseUrl = "https://api.jikan.moe/" //the api's base url - var page: Int = 1 - - override fun onCreateView( - inflater: LayoutInflater, container: ViewGroup?, - savedInstanceState: Bundle? - ): View? { - // Inflate the layout for this fragment - val view = inflater.inflate(R.layout.top_manga_page, container, false) - - sharedPreferences = view.context.getSharedPreferences("sp_manga", Context.MODE_PRIVATE) - - val mangaList: List? = getDataFromCache() - if (mangaList != null) { - showList(view, mangaList) - } else { - makeApiCall(view, baseUrl, 1) - } - - return view - - } - - private fun getDataFromCache(): List? { - //the value of the mangaList json, if nothing is found, return null - val jsonManga: String? = sharedPreferences.getString("jsonMangaList", null) - - //if it's null, well, return null - return if (jsonManga == null) { - null - } else { //else deserialize the list and return it - val listType: Type = object : TypeToken>() {}.type - gson.fromJson(jsonManga, listType) - } - } - - override fun onViewCreated(view: View, savedInstanceState: Bundle?) { - super.onViewCreated(view, savedInstanceState) - - //button to return to the home page - view.findViewById